bigpickle/sigil
0
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix R2: bootstrap hygiene — one live seed, clear siblings on enrol #6

Merged
leora merged 1 commits from leora/fix-r2-bootstrap-hygiene into sigil-initial 2026-10-06 06:12:26 +08:00
Conversation 0 Commits 1 Files Changed 4 +110 -9
leora commented 2026-10-06 06:12:24 +08:00
Contributor
Copy Link

Summary

Independent review R2 (Medium): leftover bootstrap secrets remained usable for enrol_rekey after enrol.

Changes

  • put_bootstrap spends prior unspent secrets for the agent (one live seed)
  • clear_bootstrap_for_agent called after successful enrol / enrol_rekey
  • Dual-enrol race test plants two live secrets directly (hygiene bypass)
  • Regression tests for leftover-after-enrol/rekey and one-live-secret

Test plan

  • unittest discover (137 passed)
## Summary Independent review **R2 (Medium)**: leftover bootstrap secrets remained usable for `enrol_rekey` after enrol. ## Changes - `put_bootstrap` spends prior unspent secrets for the agent (one live seed) - `clear_bootstrap_for_agent` called after successful enrol / enrol_rekey - Dual-enrol race test plants two live secrets directly (hygiene bypass) - Regression tests for leftover-after-enrol/rekey and one-live-secret ## Test plan - [x] unittest discover (137 passed)
leora added 1 commit 2026-10-06 06:12:25 +08:00 
Unspent bootstrap secrets accumulated and remained usable for enrol_rekey
after enrol. put_bootstrap now spends prior unspent seeds for the agent
(one live secret), and successful enrol / enrol_rekey clear any siblings.
Regression tests cover leftover-after-enrol, one-live-secret, and
leftover-after-rekey.
leora merged commit 2e0900e15b into sigil-initial 2026-10-06 06:12:26 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bigpickle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bigpickle/sigil#6
No description provided.
Delete Branch "leora/fix-r2-bootstrap-hygiene"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?